Adjust JNI targets #474
Merged
Adjust JNI targets #474
+12
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_854327276
branch
from
2532b43 to
1ea952a
Compare
Removes `color/internal/jni:native`. The targets following that pattern are supposed to be JNI interface targets, but this one didn't contain JNI interface at all. It contained only helper code, which consumers are already getting from the more specific `:color_jni_helper` target. Rename the other JNI interface targets from `[module]/internal/jni:native` to just `module/internal/jni` for brevity. Stop depending on `brush/internal/jni` from `strokes/internal/jni` for consistency. The other targets reflect the JNI interface of a single module, not the interface of a module and that module's dependencies. Move `rendering/skia/common_internal/jni` to `rendering/android/internal/jni` for consistency and to clarify that's Android-specific code which doesn't introduce a C++ Skia dependency. PiperOrigin-RevId: 855902247
copybara-service
bot
force-pushed
the
test_854327276
branch
from
1ea952a to
8755e16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust JNI targets
Removes
color/internal/jni:native. The targets following that pattern are supposed to be JNI interface targets, but this one didn't contain JNI interface at all. It contained only helper code, which consumers are already getting from the more specific:color_jni_helpertarget.Rename the other JNI interface targets from
[module]/internal/jni:nativeto justmodule/internal/jnifor brevity.Stop depending on
brush/internal/jnifromstrokes/internal/jnifor consistency. The other targets reflect the JNI interface of a single module, not the interface of a module and that module's dependencies.Move
rendering/skia/common_internal/jnitorendering/android/internal/jnifor consistency and to clarify that's Android-specific code which doesn't introduce a C++ Skia dependency.