Skip to content

Annotate Guice *BindingBuilder#to* APIs with @CanIgnoreReturnValue. #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Apr 29, 2025
+15 −2
Merged

Annotate Guice *BindingBuilder#to* APIs with @CanIgnoreReturnValue. #1899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions core/src/com/google/inject/binder/LinkedBindingBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

package com.google.inject.binder;

import com.google.errorprone.annotations.CanIgnoreReturnValue;
import com.google.inject.Key;
import com.google.inject.Provider;
import com.google.inject.TypeLiteral;
Expand All @@ -30,12 +31,15 @@
public interface LinkedBindingBuilder<T> extends ScopedBindingBuilder {

/** See the EDSL examples at {@link com.google.inject.Binder}. */
@CanIgnoreReturnValue
ScopedBindingBuilder to(Class<? extends T> implementation);

/** See the EDSL examples at {@link com.google.inject.Binder}. */
@CanIgnoreReturnValue
ScopedBindingBuilder to(TypeLiteral<? extends T> implementation);

/** See the EDSL examples at {@link com.google.inject.Binder}. */
@CanIgnoreReturnValue
ScopedBindingBuilder to(Key<? extends T> targetKey);

/**
Expand All @@ -50,6 +54,7 @@ public interface LinkedBindingBuilder<T> extends ScopedBindingBuilder {
*
* @see com.google.inject.Injector#injectMembers
*/
@CanIgnoreReturnValue
ScopedBindingBuilder toProvider(Provider<? extends @Nullable T> provider);

/**
Expand All @@ -58,30 +63,38 @@ public interface LinkedBindingBuilder<T> extends ScopedBindingBuilder {
* @see com.google.inject.Injector#injectMembers
* @since 4.0
*/
@CanIgnoreReturnValue
ScopedBindingBuilder toProvider(jakarta.inject.Provider<? extends @Nullable T> provider);

/** See the EDSL examples at {@link com.google.inject.Binder}. */
ScopedBindingBuilder toProvider(Class<? extends jakarta.inject.Provider<? extends @Nullable T>> providerType);
@CanIgnoreReturnValue
ScopedBindingBuilder toProvider(
Class<? extends jakarta.inject.Provider<? extends @Nullable T>> providerType);

/** See the EDSL examples at {@link com.google.inject.Binder}. */
@CanIgnoreReturnValue
ScopedBindingBuilder toProvider(
TypeLiteral<? extends jakarta.inject.Provider<? extends @Nullable T>> providerType);

/** See the EDSL examples at {@link com.google.inject.Binder}. */
ScopedBindingBuilder toProvider(Key<? extends jakarta.inject.Provider<? extends @Nullable T>> providerKey);
@CanIgnoreReturnValue
ScopedBindingBuilder toProvider(
Key<? extends jakarta.inject.Provider<? extends @Nullable T>> providerKey);

/**
* See the EDSL examples at {@link com.google.inject.Binder}.
*
* @since 3.0
*/
@CanIgnoreReturnValue
<S extends T> ScopedBindingBuilder toConstructor(Constructor<S> constructor);

/**
* See the EDSL examples at {@link com.google.inject.Binder}.
*
* @since 3.0
*/
@CanIgnoreReturnValue
<S extends T> ScopedBindingBuilder toConstructor(
Constructor<S> constructor, TypeLiteral<? extends S> type);
}
Loading