Add a regression test for a bug from an earlier iteration of the MethodHandles implementation #1891
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odHandles implementation If a `javax.inject.Provider` was bound in a scope, we would enforce that it was a `com.google.inject.Provider` which was wrong. This is due to logic in `MoreTypes.canonicalizeForKey` which canonicalizes `javax.inject.Provider` to the guice interface. This behavior makes sense for injection points since guice only ever hands out `com.google.inject.Provider` instances but we don't always canonicalize them at every phase of injection which is what lead to the bug. Now we no longer use `Dependency` objects to enforce types so we don't risk this issue anymore PiperOrigin-RevId: 741155148
copybara-service
bot
force-pushed
the
test_741129931
branch
from
fed8cb1 to
fba0e10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a regression test for a bug from an earlier iteration of the MethodHandles implementation
If a
javax.inject.Providerwas bound in a scope, we would enforce that it was acom.google.inject.Providerwhich was wrong. This is due to logic inMoreTypes.canonicalizeForKeywhich canonicalizesjavax.inject.Providerto the guice interface.This behavior makes sense for injection points since guice only ever hands out
com.google.inject.Providerinstances but we don't always canonicalize them at every phase of injection which is what lead to the bug. Now we no longer useDependencyobjects to enforce types so we don't risk this issue anymore