Skip to content

Conversation

@mkkassem
Copy link
Collaborator

Signed-off-by: Mohamed Kassem [email protected]

Fixes google/gf180mcu-pdk#94

  • a future update should include taking a point from the sim-vs-si report and show how an independent user can find what simulation and pvt corners that cause the error.

Signed-off-by: Mohamed Kassem <[email protected]>
Signed-off-by: Mohamed Kassem <[email protected]>
Signed-off-by: Mohamed Kassem <[email protected]>
Signed-off-by: Mohamed Kassem <[email protected]>
@mkkassem mkkassem changed the title Mkkassem patch 1 Update xyce regression tests README to include information about how to interpret the results Nov 14, 2022
@mithro mithro requested a review from proppy November 14, 2022 15:52
2. measured folder that contains measured data used in regression.
3. simulated folder that contains simulated data used in regression.
4. netlists folder that contains spice files used in simulation.
It's important to check the `run_log.log` to see the error per device.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we give an idea of what the acceptable pourcentage rate is?

2. measured folder that contains measured data used in regression.
3. simulated folder that contains simulated data used in regression.
4. netlists folder that contains spice files used in simulation.
It's important to check the `run_log.log` to see the error per device.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we give an idea of what the acceptable pourcentage rate is?

## Regression Usage

To make a full test for GF180nm models-ngspice, you could use the following command in testing directory:
- To make a full test for GF180nm models-ngspice, you could use the following command in testing directory:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/GF180nm/GF180MCU/ ?

## Regression Usage

To make a full test for GF180nm models-xyce, you could use the following command in testing directory:
- To make a full test for GF180nm models-xyce, you could use the following command in testing directory:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/GF180nm/GF180MCU/ ?

Copy link
Member

@proppy proppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits.

@proppy proppy changed the title Update xyce regression tests README to include information about how to interpret the results Update ngspice/xyce regression tests README to include information about how to interpret the results Nov 14, 2022
proppy pushed a commit to proppy/globalfoundries-pdk-libs-gf180mcu_fd_pr that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update xyce regression tests README to include information about how to interpret the results

2 participants