Skip to content

Cairo Play: Version 3.130;gftools[0.9.24.dev9+gaf4c611] added#5947

Closed
RosaWagner wants to merge 1 commit intomainfrom
gftools_packager_ofl_cairoplay
Closed

Cairo Play: Version 3.130;gftools[0.9.24.dev9+gaf4c611] added#5947
RosaWagner wants to merge 1 commit intomainfrom
gftools_packager_ofl_cairoplay

Conversation

@RosaWagner
Copy link
Copy Markdown
Contributor

ad4f001: [gftools-packager] Cairo Play: Version 3.130;gftools[0.9.24.dev9+gaf4c611] added

…c611] added

* Cairo Play Version 3.130;gftools[0.9.24.dev9+gaf4c611] taken from the upstream repo https://github.com/Gue3bara/Cairo at commit Gue3bara/Cairo@617ed31.
@RosaWagner RosaWagner added - Ready for Review I Small Fix bugs fixed but nothing added III Improve rendering / layout by addition of manual hinting, kerning or else labels Mar 1, 2023
@RosaWagner RosaWagner linked an issue Mar 1, 2023 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 1, 2023

Fontbakery report

Fontbakery version: 0.8.10

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('slnt-wght', 1) [code: summary]


[19] CairoPlay[slnt,wght].ttf
🔥 FAIL: Check METADATA.pb parse correctly. (com.google.fonts/check/metadata/parses)
  • 🔥 FAIL Family metadata at ofl/cairoplay failed to parse.
    TRACEBACK:
    34:1 : Message type "google.fonts_public.FamilyProto" has no field named "primary_script". [code: parsing-error]
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x0308 (COMBINING DIAERESIS)

    • 0x0300 (COMBINING GRAVE ACCENT)

    • 0x0301 (COMBINING ACUTE ACCENT)

    • 0x030B (COMBINING DOUBLE ACUTE ACCENT)

    • 0x0304 (COMBINING MACRON)

    • 0x0132 (LATIN CAPITAL LIGATURE IJ)

    • 0x1E9E (LATIN CAPITAL LETTER SHARP S)

    • 0x0133 (LATIN SMALL LIGATURE IJ)

    • 0x0307 (COMBINING DOT ABOVE)

    • 0x0302 (COMBINING CIRCUMFLEX ACCENT)

    • And 7 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check variable font instances (com.google.fonts/check/fvar_instances)
  • 🔥 FAIL fvar instances are incorrect:
  • Add missing instances
Name current expected
ExtraLight Italic N/A wght=200.0, slnt=-11.0
ExtraLight wght=200.0, slnt=0.0 wght=200.0, slnt=0.0
Light Italic N/A wght=300.0, slnt=-11.0
Light wght=300.0, slnt=0.0 wght=300.0, slnt=0.0
Italic N/A wght=400.0, slnt=-11.0
Regular wght=400.0, slnt=0.0 wght=400.0, slnt=0.0
Medium Italic N/A wght=500.0, slnt=-11.0
Medium wght=500.0, slnt=0.0 wght=500.0, slnt=0.0
SemiBold Italic N/A wght=600.0, slnt=-11.0
SemiBold wght=600.0, slnt=0.0 wght=600.0, slnt=0.0
Bold Italic N/A wght=700.0, slnt=-11.0
Bold wght=700.0, slnt=0.0 wght=700.0, slnt=0.0
ExtraBold Italic N/A wght=800.0, slnt=-11.0
ExtraBold wght=800.0, slnt=0.0 wght=800.0, slnt=0.0
Black Italic N/A wght=900.0, slnt=-11.0
Black wght=900.0, slnt=0.0 wght=900.0, slnt=0.0
WARN: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN For now we're still accepting http URLs, but you should consider using https instead.
    [code: http]
WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]
  • WARN For now we're still accepting http URLs, but you should consider using https instead.
    [code: http]
WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Glyph names are all valid? (com.google.fonts/check/valid_glyphnames)
  • WARN The following glyph names may be too long for some legacy systems which may expect a maximum 31-char length limit:
    alefMaksura_alefMaksuraar.fina.alt, yehHamzaabove_yehHamzaabovear.fina, alefMaksura_noonar.fina.alt.color0, alefMaksura_noonar.fina.alt.color1, noon_yehHamzaabovear.fina.color0, noon_yehHamzaabovear.fina.color1, noon_yehHamzaabovear.fina.color2, seen_yehHamzaabovear.fina.color0, seen_yehHamzaabovear.fina.color1, sheen_yehHamzaabovear.fina.color0 and 13 more.

Use -F or --full-lists to disable shortening of long lists. [code: legacy-long-names]

WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • at.cap

    • braceleft.cap

    • braceright.cap

    • bracketleft.cap

    • bracketright.cap

    • connection_r

    • dotcenterar

    • eight.pnum

    • emdash.cap

    • endash.cap

    • And 20 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Check GDEF mark glyph class doesn't have characters that are not marks. (com.google.fonts/check/gdef_non_mark_chars)
  • WARN The following non-mark characters should not be in the GDEF mark glyph class:
    U+FBB2, U+FBB3, U+FBB4, U+FBB5, U+FBB6, U+FBB7, U+FBB8, U+FBB9, U+FBBD and U+FBBE [code: non-mark-chars]
INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/cairoplay/CairoPlay[slnt,wght].ttf
Dehinted Size 598.7kb
Hinted Size 598.7kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 3.130;gftools[0.9.24.dev9+gaf4c611]'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 3.130;gftools[0.9.24.dev9+gaf4c611]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • And gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/cairoplay [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 3 8 89 9 118 0
0% 1% 4% 39% 4% 52% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner requested a review from m4rc1e March 1, 2023 17:12
Copy link
Copy Markdown
Collaborator

@m4rc1e m4rc1e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

Screenshot 2023-03-02 at 09 56 21

After:

Screenshot 2023-03-02 at 09 56 40

Only issue is what appears to be missing kerns on the Reh:

Screenshot 2023-03-02 at 09 57 36

Since this fixes a major issue, we should merge it.

cc @yanone

@yanone
Copy link
Copy Markdown
Contributor

yanone commented Mar 6, 2023

Holding this back because Khaled may have fixed the glyphsLib issue that led to the duplicate red layer. Will check today and report back

@yanone
Copy link
Copy Markdown
Contributor

yanone commented Mar 6, 2023

I'm closing this because I manually added CairoPlay to the other PR #5924 and now I don't know how to undo it, so committing new versions over there.

@yanone yanone closed this Mar 6, 2023
@yanone yanone deleted the gftools_packager_ofl_cairoplay branch March 6, 2023 13:55
@RosaWagner
Copy link
Copy Markdown
Contributor Author

@yanone Please let's try to avoid manual addition, and let's keep PRs separated. We need the commit numbers to be in sync, and to track fonts individually once merged. Close the other one and re-do it if there is something wrong.

@yanone
Copy link
Copy Markdown
Contributor

yanone commented Mar 6, 2023

Okay he merged my PR in the meantime. I can redo both of them officially now

@yanone yanone removed a link to an issue Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I Small Fix bugs fixed but nothing added III Improve rendering / layout by addition of manual hinting, kerning or else

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants