fix: handle NaN in ClampFloat64 and L1 sensitivity overflow in Laplac…#411
Open
AndyBurecovics wants to merge 1 commit intogoogle:mainfrom
Open
fix: handle NaN in ClampFloat64 and L1 sensitivity overflow in Laplac…#411AndyBurecovics wants to merge 1 commit intogoogle:mainfrom
AndyBurecovics wants to merge 1 commit intogoogle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ClampFloat64ingo/dpagg/helpers.godoes not handle NaN inputs. IEEE 754 comparisons with NaN always return false, so NaN passes through both the> upperand< lowerchecks and gets returned as-is.NaN reaches
ClampFloat64through an L1 sensitivity overflow in the Laplace noise layer. InAddNoiseFloat64,l1 = lInfSensitivity * float64(l0Sensitivity)can overflow to +Inf when both operands are individually valid.ceilPowerOfTwo(+Inf)returns NaN, which propagates through the entire noise computation. The same issue affectsAddNoiseInt64where the int64 multiplication wraps silently.Aggregations like
BoundedVariance,BoundedMean, andBoundedStandardDeviationare affected since they derive internal bounds that can pushlInfSensitivityclose toMaxFloat64.Fix
math.IsNaN(e)check at the top ofClampFloat64, returning the lower bound with an error.l1Sensitivityis finite after multiplication inAddNoiseFloat64.AddNoiseInt64.Related: https://issuetracker.google.com/issues/500383618