Validate decoded fields in GobDecode to prevent nil noise, invalid bounds, and division by zero#404
Open
AndyBurecovics wants to merge 1 commit intogoogle:mainfrom
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…unds, and division by zero
AndyBurecovics
force-pushed
the
fix/gobdecode-validation
branch
from
4ba1513 to
bcb8e03
Compare
Collaborator
There was a problem hiding this comment.
It might make sense to move this to go/checks/ directory.
| if err != nil { | ||
| return fmt.Errorf("couldn't decode BoundedSumFloat64 from bytes") | ||
| } | ||
| nObj2, err := validateDecodedAggregation(enc.Epsilon, enc.Delta, enc.LInfSensitivity, enc.L0Sensitivity, enc.NoiseKind) |
| if err != nil { | ||
| return fmt.Errorf("couldn't decode BoundedMean from bytes") | ||
| } | ||
| if err := checks.CheckBoundsFloat64(enc.Lower, enc.Upper); err != nil { |
Collaborator
There was a problem hiding this comment.
For mean & variance, I think we could call validateDecodedAggregation on the underlying Count and Sum objects for completeness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GobDecode functions in the dpagg package do not validate deserialized fields, allowing crafted payloads to produce aggregation objects that panic or return incorrect results on Result().
This patch adds post-decode validation mirroring the checks already enforced by constructors:
A new helper file gobdecode_checks.go centralizes the common validation logic.