add spark runner documentation#367
Open
leroyjb wants to merge 28 commits intogoogle:mainfrom
Open
Conversation
RamSaw
requested changes
Dec 3, 2025
Collaborator
RamSaw
left a comment
RamSaw
left a comment
There was a problem hiding this comment.
Looks good, thank you! Let's fix small nits, I will take another look and submit likely.
| "org.scala-lang:scala-library:%s" % SCALA_LIBRARY_TAG, | ||
| "info.picocli:picocli:4.7.6", | ||
| # For Apache Spark Runner testing locally | ||
| "org.apache.spark:spark-streaming_%s:%s" % (2.12, SPARK_TAG), |
Collaborator
There was a problem hiding this comment.
why it should be here and the other deps in separate maven install?
RamSaw
reviewed
Mar 26, 2026
| @@ -0,0 +1,36 @@ | |||
| # Copyright 2024 Google LLC | |||
Collaborator
There was a problem hiding this comment.
there is already examples/pipelinedp4j/beam/src/main/java/com/google/privacy/differentialprivacy/pipelinedp4j/examples/BUILD.bazel
| <?xml version="1.0" encoding="UTF-8"?> | ||
|
|
||
| <!-- | ||
| Copyright 2024 Google LLC |
Collaborator
There was a problem hiding this comment.
could you revert these formatting changes for better diff?
RamSaw
reviewed
Mar 26, 2026
| @@ -0,0 +1,36 @@ | |||
| # Copyright 2024 Google LLC | |||
|
|
||
| View the results with `cat output-spark-runner.txt`. | ||
|
|
||
| # Build and execute locally |
RamSaw
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.