[Tracing] Emiting TestcaseRejectionEvent during corpus pruning
#4848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniciustCosta
requested changes
Jul 1, 2025
There was a problem hiding this comment.
I think this is the same case as #4847, where testcase rejection does not seem like the correct event to be emitting here :/
|
Incorrectly emitting events for existing instead of the new one. The new one is never promoted to a testcase so it does not make sense to emit anything here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the emits of
TestcaseRejectionEventin the desired steps of the corpus pruning task life cycle as stated in the "Testcase rejection" section of "Lightweight Clusterfuzz Tracing" doc.We are also adding assertions for verification of the emit.
The other remaining cases where
TestcaseRejectionEventmust be emitted (namely grouper) will be addressed in separate PRs.b/394056013