[Tracing] Emiting TestcaseRejectionEvent during triage
#4827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will do a full review later, but just a heads up to avoid merging this one before actually testing it, since it touches critical part of the code (triage). |
vitorguidi
reviewed
Jun 13, 2025
| @@ -262,10 +263,20 @@ def _check_and_update_similar_bug(testcase, issue_tracker): | |||
| # might be caused by non-availability of latest builds. In that case, | |||
| # don't file a new bug yet. | |||
| if similar_testcase.open and not similar_testcase.one_time_crasher_flag: | |||
| events.emit( | |||
There was a problem hiding this comment.
Now that I think of it, this event will be emited multiple times until the testcase itself is marked as closed, or something else that prevents it from entering this triage loop indefini.
It is not as simple as it looked from the start, we need to check the cleanup code to understand if that might be correct place to emit
There was a problem hiding this comment.
This seems to be the better place to emit this stuff
vitaliset
added a commit
that referenced
this pull request
Jun 15, 2025
While writing #4827, I realized this pattern might be a better way of asserting the emits (which is pretty similar to what we are doing in `events_test.py` anyway). Co-authored-by: Carlo Lemos <[email protected]>
|
Superseded by #4846. |
vitaliset
added a commit
that referenced
this pull request
Jul 2, 2025
This PR introduces the emits of `TestcaseRejectionEvent` in the desired steps of the cleanup task life cycle as discussed in the [comment section](#4827 (comment)) of #4827. Supersedes #4827. The other remaining cases where `TestcaseRejectionEvent` must be emitted (namely fuzz task, corpus pruning and grouper) will be addressed in separate PRs. b/394056013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the emits of
TestcaseRejectionEventin the desired steps of the triage task life cycle as stated in the "Testcase rejection" section of "Lightweight Clusterfuzz Tracing" doc.We are also adding assertions for verification of the emit.
The other remaining cases where
TestcaseRejectionEventmust be emitted (namely fuzz task and corpus pruning) will be addressed in separate PRs.b/394056013