-
Notifications
You must be signed in to change notification settings - Fork 317
Add support for initial alpha value for SAC #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
btaba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Can you comment on the practical usage and range of initial_alpha that has shown some improvement in your applications?
Hi @btaba. I apologize for the late response. I am trying to implement a brax version of A Walk In The Park and their config file uses |
ab7f75c to
9453c7c
Compare
9453c7c to
82ffc9f
Compare
|
@btaba I updated the PR comment to describe what I am trying to do better and I merged in the latest HEAD. Can you please review this when you get a chance? |
I am trying to implement a brax version of A Walk In The Park and their config file uses$\alpha$ value (or initial temperature) in SAC.
init_temperature=0.1which is theThe current version of SAC in brax hard codes the$\alpha$ value to 1.0 by setting $\alpha$ as a paramater.
log_alpha = 0.0.Thus this PR adds the option to specify the
Additionally, I have added a detailed docstring for the SAC
trainfunction.