Bump GitHub Actions versions to fix artifact upload #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump upload-artifact to v4 for the cmake workflow since v3 was deprecated and disabled.
The macos-12 image was removed on 12/3/24.
The `runner` object isn't documented to have a `workspace` member. Switch to using the documented `github.workspace` variable. https://docs.github.com/de/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#runner-context
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I just realized this is partly covered by #147 too. |
colinmkinsella
added a commit
to colinmkinsella/binexport
that referenced
this pull request
Jun 8, 2025
…rom PR google#152, PR google#150, and the things I didn't have in PR google#151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cmake workflow building the C++ project fails to upload artifacts for a while due to the upload-artifact Action changing the backend in v4 to be incompatible with v3 forcing everyone to update.
The macos-12 runner image was removed on 12/3/24 so update to the next oldest available one. I'm not sure the build dependencies are meant to be old to allow running on older versions?
Build Ghidra plugins for all newer Ghidra versions too for easy installation of whatever version you're running.
I couldn't test the workflow in my fork due to the encrypted idasdk requirement.