Feat: Dynamic authentication handling in MCPToolset from Adk ReadonlyContext.state using Callback #1198
+2,428
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
pandasanjay
force-pushed
the
stdio_mcp_passing_env_from_adk_state
branch
3 times, most recently
from
6b9f641 to
673d387
Compare
…riable functionality - Updated test_mcp_toolset_auth.py to improve code readability and maintainability by restructuring imports and fixtures. - Added new test cases to validate the behavior of MCPToolset with both authentication and environment callbacks. - Enhanced mock setups to ensure proper isolation of tests and avoid dependency issues. - Refactored test assertions for clarity and consistency. - Updated test_mcp_toolset_env.py to rename environment transform callback for clarity and improved structure. - Ensured that tests validate the integration of environment variable extraction and injection with the MCPToolset.
pandasanjay
force-pushed
the
stdio_mcp_passing_env_from_adk_state
branch
from
afd46e2 to
f257b9a
Compare
pandasanjay
changed the title
pandasanjay
changed the title
pandasanjay
changed the title
…o_mcp_passing_env_from_adk_state
….com/pandasanjay/adk-python into stdio_mcp_passing_env_from_adk_state
pandasanjay
changed the title
pandasanjay
changed the title
pandasanjay
changed the title
|
Hi @seanzhou1023, Apologies for tagging you directly. I noticed you've recently reviewed several of the MCPTools. If you have a moment, could you take a look at this pull request? Your feedback would be greatly appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add authentication information to MCPToolset from Adk ReadonlyContext.state
This PR implements dynamic authentication handling in MCPToolset by passing authentication information (such as user-specific tokens) directly from the Adk session.state. With this approach, user tokens can be injected and sent from the ADK Context state to MCP, supporting user-specific authentication flows.
Key Improvements:
Dynamic Token Management:
Improved Unit Tests: Enhancements for better readability and maintainability.
New Sample: Demonstrates passing user tokens to MCP via environment variables, showcasing the dynamic flow from session.state.
Flexible & Secure Integration: Allows for more flexible and secure integration scenarios, supporting distinct authentication credentials per session or user.
#805 - Partially added ability to pass Authentication Details from ReadonlyContext, if the same JWT token can be reused.
#1402 - Fully support for the STDIO Transport.