fix: load SKILL.md files with tables#500
Merged
Merged
Conversation
SKILL.md files were not being properly loaded when tables were present, since these use the string `"---"` as a delimiter as well. Added a test for this and fixed an integration test's testcase data.
kalenkevich
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
SKILL.md files failed to load properly when tables were present, because tables and the frontmatter header both use
"---"as a delimiter.Solution:
Instead of using only the third part of the split file as a body, all the parts starting from it are re-joined with the delimiter string.
Added a test for this and fixed an integration test's testcase data.
Testing Plan
Added and fixed a failing unit test, tested the changed package itself in a separate project.
Some unrelated e2e tests are failing due to not having credentials properly configured.
Unit Tests:
Manual End-to-End (E2E) Tests:
Have an agent load a skill with a table in its SKILL.md file, validate that the entire file has been loaded.
Checklist
Additional context
Before
After