fix: gracefully handle missing function calls during context compaction#496
Merged
kalenkevich merged 2 commits intoJul 15, 2026
Merged
Conversation
kalenkevich
approved these changes
Jul 15, 2026
ScottMansfield
requested changes
Jul 15, 2026
ScottMansfield
left a comment
ScottMansfield
left a comment
Member
There was a problem hiding this comment.
Seems dangerous to remove a thrown error and just silently drop function events. Instead of fixing the new compaction here, the compaction should properly adjust history so it does not happen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an integration test regression introduced in PR #430 where a newly tightened safety check around
functionResponsematching causes a crash if context compaction executes and strips away the parentfunctionCallfrom the history. By returningevents.slice(0, -1), we gracefully ignore the orphaned response instead of throwing a fatal error.