Feat: Cleanup and Generalize determineAgentForResumption for LRO Session Resumption Routing#490
Merged
kalenkevich merged 4 commits intoJul 15, 2026
Conversation
kalenkevich
added a commit
to AmaadMartin/adk-js
that referenced
this pull request
Jul 15, 2026
kalenkevich
approved these changes
Jul 15, 2026
kalenkevich
added a commit
that referenced
this pull request
Jul 15, 2026
kalenkevich
force-pushed
the
feat/lro-session-resumption-routing
branch
from
July 15, 2026 21:22
e86c4aa to
632fe1c
Compare
…econd timestamp collisions during fast in-memory integration tests
Merged
kalenkevich
added a commit
that referenced
this pull request
Jul 15, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
Link to an existing issue (if applicable):
Or, if no issue exists, describe the change:
Problem: In
adk-js, when a session resumes after a long-running tool invocation or Long Running Operation (LRO) completion across session boundaries,determineAgentForResumptionneeded cleanup and generalization to properly route execution back to the initiating sub-agent. Furthermore,adk-jslacked architectural parity withadk-python'sResumabilityConfigguarding, and had brittle assumptions where unresolved agent authors from a function response immediately defaulted torootAgentwithout falling through to the transferable LLM agent scan.Solution:
ResumabilityConfig(core/src/apps/resumability_config.ts) and integrated it intoRunnerConfigandRunnerto align with Python's reference architecture (runners.py).findMatchingFunctionCallandfindEventByFunctionCallId) incore/src/agents/functions.ts, and standalone resumption utilities (determineAgentForResumptionandisRoutableLlmAgent) incore/src/runner/runner.ts.determineAgentForResumptionto checkresumabilityConfig.isResumablewhen matching past function responses, and cleanly fall through to Case 2 (isRoutableLlmAgentscan) with a descriptive warning if the author is no longer found inrootAgent.Testing Plan
Please describe the tests that you ran to verify your changes. This is required for all PRs that are not small documentation or typo fixes.
Unit Tests:
Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any necessary setup or configuration.
Run the local end-to-end verification test verifying multi-agent LRO resumption routing across serialized session boundaries without mocks:
npx vitest run tests/e2e/routing/lro_resumption_routing_e2e_test.tsChecklist