Skip to content

docs: Update llm-agents with built in planner example.md #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 15, 2025

Conversation

kanlanc
Copy link
Contributor

@kanlanc kanlanc commented Apr 30, 2025

Created a draft version for the issue #173

@wietsevenema , @hangfei would love your thoughts on should be added or removed to this, I added some comments on the issue directly about adding validation on the models that support the thinking config itself.

Finally, if there is an ideal number on what should be the thinking budget usually

Some things I wasn't too clear on my lack of creativity with what would be an ideal situation to demonstrate the planner capabilities.

Copy link

google-cla bot commented Apr 30, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kanlanc kanlanc marked this pull request as draft April 30, 2025 19:19
@kanlanc kanlanc marked this pull request as ready for review May 2, 2025 19:30
@kanlanc
Copy link
Contributor Author

kanlanc commented May 3, 2025

@wietsevenema , @hangfei , @boyangsvl

Hey guys,

Would love some direction for the above questions so I can move forward more on this

@lavinigam-gcp lavinigam-gcp self-requested a review May 30, 2025 08:26
@lavinigam-gcp
Copy link
Collaborator

@kanlanc Hey Vikranth, sorry for the delay. I will be reviewing your PR and help you get this merged. :)

@lavinigam-gcp
Copy link
Collaborator

@kanlanc I have requested few changes, and I have tested the updated code at my end. Once fixed, will merge. Thank you again for taking time to add this example! :)

@Sita04
Copy link
Collaborator

Sita04 commented Jul 8, 2025

Hi @kanlanc,

Just fyi, I've made changes to the Planner doc to include info on BuiltInPlanner and PlanReActPlanner. But you can still go ahead and modify the "Full Example" and merge this PR.

@joefernandez
Copy link
Collaborator

BLOCKED due to commit message compliance.

@joefernandez joefernandez changed the title Update llm-agents with built in planner example.md docs: Update llm-agents with built in planner example.md Aug 15, 2025
@joefernandez joefernandez merged commit 75b6d8a into google:main Aug 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants