[gn] add standalone modules#10501
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_933298797
branch
2 times, most recently
from
ebc7afe to
86e89a8
Compare
Chrome provides a libpthreadpool implementation in //base, which sends tasks to Chrome's threadpool. However, there are some parts of Chrome that cannot use this, hence XNNPACK is built twice for those configurations. This should resolve the final cluster of issues in [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/7615883 PiperOrigin-RevId: 933653185
copybara-service
Bot
force-pushed
the
test_933298797
branch
from
86e89a8 to
f5a3ba0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[gn] add standalone modules
Chrome provides a libpthreadpool implementation in //base, which sends
tasks to Chrome's threadpool. However, there are some parts of Chrome
that cannot use this, hence XNNPACK is built twice for those
configurations.
This should resolve the final cluster of issues in [1].
[1] https://chromium-review.googlesource.com/c/chromium/src/+/7615883