fix(tools): update QA tooling, rules, exclusions, and relative path logging - #1322
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on repository-wide maintenance and standardization. The primary goal is to ensure consistency across all Jupyter notebooks using the project's internal formatting and linting tools. Additionally, it improves developer documentation for these tools and cleans up repository ignore rules. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the repository's .gitignore to ignore Python cache artifacts and revises CONTRIBUTING.md to use the in-repo formatting and linting tools (nbfmt_cli.py and nblint_cli.py) instead of the deprecated tensorflow_docs tools. Additionally, numerous example notebooks are updated to use the new google-genai SDK (from google import genai) and to install the correct package version (google-genai>=2.9.0). Since the only review comment was on a file not modified in this pull request, it has been removed, and I have no further feedback to provide.
908ed2b to
57416b1
Compare
ba834fb to
fb31f5e
Compare
… and capability-sorted lists
Summary of Changes
This PR refines the in-repo Quality Assurance and linting tools under
tools/:Table of Contents Link Checker (
tools/check_readme_links.py):/home/runner/work/cookbook/cookbook/).EXCLUDED_README_NOTEBOOKSintools/config.pyto exempt notebooks that do not require Table of Contents entries (e.g.quickstarts/Authentication_with_OAuth.ipynb).Linting Rules & Severity Handling (
tools/nblint/):style::second_personandgemini::sdk_packageasSeverity.WARNINGrather than build blockers.tools/config.py("this notebook has moved").Formatting Sanitization (
tools/nbfmt/):</a>\\n).