Precompute inverse square root of impratio #883
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't need this change in 100%. I just came across this, tried it and I can see a slight edge in benchmarks/kernel timings. Nothing compared to the bigger things we still have to optimize though.
That being said, apart from the interface change I think this has only benefits, as it removes runtime square root instructions in some kernel that run very often (linesearch) and sqrt throughput is generally lower than multiplication. My intuition and a very quick experiment tell me that a non-default impratio that doesn't have a trivial solution to sqrt makes these gains more visible.
Numbers for humanoid on an RTX Pro 6000 Blackwell.
impratio == 1:
main:
this pr:
Impratio == 7:
main:
this pr: