Fix race condition in chexify #271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_534012863
branch
from
2cb4333 to
b81c11a
Compare
copybara-service
bot
changed the title
When called with multiple threads in async mode, a chexified function and `block_until_chexify_assertions_complete` both access the internal futures queue without synchronization. This adds a lock around the futures queue to avoid the circumstance where the `popleft` method can be called on an empty queue, causing an uncaught `IndexError`. PiperOrigin-RevId: 534012863
copybara-service
bot
force-pushed
the
test_534012863
branch
from
b81c11a to
15dbf86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix race condition in chexify
When called with multiple threads in async mode, a chexified function and
block_until_chexify_assertions_completeboth access the internal futures queuewithout synchronization. This adds a lock around the futures queue to avoid the
circumstance where the
popleftmethod can be called on an empty queue, causingan uncaught
IndexError.