Support dynamic version for dev and releases.#617
Open
ccoulombe wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Support dynamic version for dev and releases.#617ccoulombe wants to merge 1 commit intogoogle-deepmind:mainfrom
ccoulombe wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
Collaborator
|
Wouldn't the CMake part need to be updated as well? |
Author
|
Which cmake part more precisely are you referring to?
…On Fri, Mar 6, 2026, 12:29 Augustin Žídek ***@***.***> wrote:
*Augustin-Zidek* left a comment (google-deepmind/alphafold3#617)
<#617 (comment)>
Wouldn't the CMake part need to be updated as well?
—
Reply to this email directly, view it on GitHub
<#617 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFMODOD4Y4J6FLI4IIFI3IL4PMDIHAVCNFSM6AAAAACUFYMWQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAMJTGA2DCMBZGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
|
Sorry for the late reply. Will this work correctly with this line in CMakeLists.txt: project(
"${SKBUILD_PROJECT_NAME}"
LANGUAGES CXX
VERSION "${SKBUILD_PROJECT_VERSION}")The |
Author
|
With the changes from this PR, I was able to build And adding some print status from CMake: Thus, I'd say yes. Esp. since it is From the documentation, we could infer that it manages the variable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing from
HEAD, this would allow one to have traceable reproducibility.A local wheel built today from a fresh clone, would be tagged
alphafold3-3.0.2.dev113+gebfe70a27.d20260206-cp313-cp313-linux_x86_64.whl.The version is incremented from the current tag.
A
devrelease suffix which show that113commits have been made since.A local version
+gebfe70a27.d20260206which means :gebfe70a27(g+short commit)d20260206(d+date)Hence it is easy to know which build/commit a user used as it is described in the file name.
Ref: