Black screen on showing camera frames#69
Black screen on showing camera frames#69diegomeire wants to merge 4 commits intogoogle-ar:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
judax
left a comment
There was a problem hiding this comment.
Thank you for sending a PR. I think this PR is not finished or correct, right?
| const size_t width = CVPixelBufferGetWidthOfPlane(pixelBuffer, planeIndex); | ||
| const size_t height = CVPixelBufferGetHeightOfPlane(pixelBuffer, planeIndex); | ||
|
|
||
There was a problem hiding this comment.
I guess that this is not the change you were intending to submit. Am I right?
There was a problem hiding this comment.
Not really. That's weird. The lines 66 and 518 were changed.
Maybe it's because I tried one PR before but had to undo it.
the method CVMetalTextureCacheCreateTextureFromImage was generating the error -6661 for every frame because it was expecting the _capturedImageTextureCache variable to be CVMetalTextureCacheRef rather than CVOpenGLESTextureCacheRef.
This change provides the correction to make the camera work again.