Skip to content

fix: fix positioning of block comments in RTL mode #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2025
Merged

fix: fix positioning of block comments in RTL mode #249

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1677137
fix: fix positioning of block comments in RTL mode
gonfunko Aug 4, 2025
bb29bad
chore: factor out shared constant
gonfunko Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/scratch_comment_bubble.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,14 +129,17 @@ export class ScratchCommentBubble
}

dropAnchor() {
this.moveTo(this.anchor.x + 40, this.anchor.y - 16);
this.moveTo(
this.anchor.x + 40 * (this.workspace.RTL ? -1 : 1),
this.anchor.y - 16
);
const location = this.getRelativeToSurfaceXY();
this.anchorChain = Blockly.utils.dom.createSvgElement(
Blockly.utils.Svg.LINE,
{
x1: this.anchor.x - location.x,
y1: this.anchor.y - location.y,
x2: this.getSize().width / 2,
x2: (this.getSize().width / 2) * (this.workspace.RTL ? -1 : 1),
y2: 16,
style: `stroke: ${this.sourceBlock.getColourTertiary()}; stroke-width: 1`,
},
Expand Down