Skip to content

fix: latency tests #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevenh merged 2 commits into from
Mar 15, 2025
Merged

fix: latency tests #685

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa57505
fix: argument order for require.Equal
elboulangero Mar 12, 2025
098d7d8
fix: actual latency might be longer than expected
elboulangero Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions redis/reply_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,13 +264,17 @@ func TestLatency(t *testing.T) {
require.Equal(t, 1, len(latestLatencies))

latencyEvent := latestLatencies[0]

// The actual latency might be longer than 1ms
require.GreaterOrEqual(t, latencyEvent.Latest, time.Millisecond)
require.GreaterOrEqual(t, latencyEvent.Max, time.Millisecond)
expected := redis.Latency{
Name: "command",
Latest: time.Millisecond,
Max: time.Millisecond,
Latest: latencyEvent.Latest,
Max: latencyEvent.Max,
Time: latencyEvent.Time,
}
require.Equal(t, latencyEvent, expected)
require.Equal(t, expected, latencyEvent)
}

func TestLatencyHistories(t *testing.T) {
Expand Down Expand Up @@ -315,7 +319,8 @@ func TestLatencyHistories(t *testing.T) {

require.Len(t, latencyHistory, 1)
latencyEvent := latencyHistory[0]
require.Equal(t, time.Millisecond, latencyEvent.ExecutionTime)
// The actual latency might be longer than 1ms
require.GreaterOrEqual(t, latencyEvent.ExecutionTime, time.Millisecond)
}

// dial wraps DialDefaultServer() with a more suitable function name for examples.
Expand Down