Feature/mfa step1 interfaces

[gomminjae]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the application's architecture by introducing an interface-based modular design for its features. The changes aim to improve maintainability, testability, and scalability by decoupling feature implementations from the main application flow and coordinator. Dependency injection, facilitated by Swinject and a new CompositionRoot, is now used to provide view factories, ensuring a cleaner and more organized dependency graph. This foundational work sets the stage for integrating new features like multi-factor authentication with a robust and flexible structure.

Highlights

• Architectural Shift: Implemented a new interface-based modular architecture for feature modules, enhancing separation of concerns and preparing for future multi-factor authentication (MFA) features.
• Dependency Injection: Introduced Swinject and a CompositionRoot to manage and inject dependencies, replacing direct ViewModel resolution in AppCoordinator and promoting a more testable codebase.
• Feature Interfaces: Created dedicated interface modules (e.g., AuthInterface, HomeInterface) for all major features, allowing the AppCoordinator to depend on abstractions rather than concrete implementations.
• AppCoordinator Decoupling: Refactored AppCoordinator to depend solely on feature interfaces, making it more flexible, testable, and independent of specific feature implementations.
• Dependency Cleanup: Removed unused external dependencies such as ComposableArchitecture and SDWebImage from the project.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a significant architectural refactoring by implementing a factory pattern for view creation and dependency injection across the application. It centralizes view factory creation in a new CompositionRoot module, which resolves dependencies via Swinject. Feature modules now expose ViewFactory protocols, and the AppCoordinator and NewDokTabView are updated to depend on these interfaces rather than concrete ViewModel implementations, enhancing modularity and decoupling. Additionally, ComposableArchitecture and SDWebImage dependencies are removed, and various code comments are cleaned up. A minor improvement opportunity was noted regarding extracting a shared DI container property for better readability.

[gemini-code-assist]

To reduce repetition and improve readability, you can extract AppDIContainer.shared.container into a private static property. This avoids redeclaring the container variable in every factory method.

enum CompositionRoot {
    private static let container = AppDIContainer.shared.container

    static func makeAuthFactory() -> AuthViewFactory {