Feature/mfa step2 usecase split

[gomminjae]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant architectural refactoring aimed at enhancing modularity, testability, and maintainability of the application. It establishes a robust dependency injection pattern using Swinject and a factory-based approach for creating views and view models. By defining clear interfaces for features and centralizing dependency resolution, the changes effectively decouple the AppCoordinator from concrete feature implementations, resulting in a more flexible and extensible system.

Highlights

• Architectural Refactoring: Introduced a new CompositionRoot for centralized dependency resolution and view factory creation, significantly restructuring how dependencies are managed across the application.
• Dependency Inversion and Modularization: Refactored AppCoordinator and NewdokApp to depend on feature interfaces and view factories, promoting dependency inversion and decoupling the core application flow from concrete feature implementations. This involved creating *Interface targets and *ViewFactoryImpl for each feature (Auth, Home, Explore, etc.).
• Dependency Injection Framework Update: Replaced ComposableArchitecture with Swinject for dependency injection, streamlining the process of managing and providing dependencies.
• UseCase Relocation: Migrated use case implementations from the Domain module to their respective feature modules, aligning them closer to their functional areas.
• Dependency Cleanup: Removed the SDWebImage external dependency from the project.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the application's dependency injection and module structure. It introduces a new CompositionRoot for centralizing view model and use case creation using Swinject, and defines *ViewFactory protocols and implementations for each feature to decouple the AppCoordinator from concrete view implementations. The AppCoordinator now receives these factories as dependencies. Dependencies on ComposableArchitecture and SDWebImage were removed. Review comments highlight that force unwrapping of resolved dependencies in CompositionRoot.swift could lead to runtime crashes and suggest using safe unwrapping. Additionally, it is recommended that the makeTabView function in AppCoordinator should return AnyView for consistency with other factory methods and for type erasure.

[gemini-code-assist]

Force unwrapping (!) resolved dependencies can lead to runtime crashes if the dependency is not registered in the Swinject container. Consider using guard let or if let to safely unwrap, or provide a default value/error handling mechanism.

Suggested change

	let loginUseCase = LoginUseCaseImpl(userUseCase: userUseCase)
	let userUseCase = container.resolve(UserUseCase.self)!

[gemini-code-assist]

Force unwrapping (!) resolved dependencies can lead to runtime crashes if the dependency is not registered in the Swinject container. Consider using guard let or if let to safely unwrap, or provide a default value/error handling mechanism.

Suggested change

	return LoginViewModel(loginUseCase: loginUseCase)
	let loginUseCase = LoginUseCaseImpl(userUseCase: userUseCase)

[gemini-code-assist]

The makeTabView function returns some View, while other factory methods in AppCoordinator return AnyView. For consistency and to ensure type erasure if needed, consider making makeTabView also return AnyView.

Suggested change

	@MainActor func makeTabView(selectedTab: NewDokTab? = nil, exploreDay: Int? = nil, exploreSelectedTab: Int? = nil) -> some View {
	NewDokTabView(
	homeFactory: homeFactory,
	exploreFactory: exploreFactory,
	subscribeFactory: subscribeFactory,
	bookmarkFactory: bookmarkFactory,
	mypageFactory: mypageFactory,
	exploreIntent: exploreIntent,
	selectedTab: selectedTab,
	exploreDay: exploreDay,
	exploreSelectedTab: exploreSelectedTab
	).environmentObject(router)
	@MainActor func makeTabView(selectedTab: NewDokTab? = nil, exploreDay: Int? = nil, exploreSelectedTab: Int? = nil) -> AnyView {
	let tabView = NewDokTabView(
	homeFactory: homeFactory,
	exploreFactory: exploreFactory,
	subscribeFactory: subscribeFactory,
	bookmarkFactory: bookmarkFactory,
	mypageFactory: mypageFactory,
	exploreIntent: exploreIntent,
	selectedTab: selectedTab,
	exploreDay: exploreDay,
	exploreSelectedTab: exploreSelectedTab
	).environmentObject(router)
	return AnyView(tabView)
	}