refactor: MFA 0단계 — 유령 의존성 제거, 미사용 라이브러리 정리, SwipeBackHandler 이동#68
refactor: MFA 0단계 — 유령 의존성 제거, 미사용 라이브러리 정리, SwipeBackHandler 이동#68
Conversation
gomminjae
commented
Mar 26, 2026
- 6개 Feature(Bookmark, Detail, Search, Subscribe, MyPage, Launch)에서 미사용 Core 의존성 제거
- SDWebImageSwiftUI, ComposableArchitecture 외부 의존성 완전 제거
- SwipeBackHandler를 Shared → DesignSystem으로 이동 (UI 유틸리티 적절한 레이어 배치)
- AppFlowCoordinatorView에 import DesignSystem 추가
- 6개 Feature(Bookmark, Detail, Search, Subscribe, MyPage, Launch)에서 미사용 Core 의존성 제거 - SDWebImageSwiftUI, ComposableArchitecture 외부 의존성 완전 제거 - SwipeBackHandler를 Shared → DesignSystem으로 이동 (UI 유틸리티 적절한 레이어 배치) - AppFlowCoordinatorView에 import DesignSystem 추가 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 프로젝트의 의존성 구조를 리팩토링하여 사용되지 않는 의존성을 제거하고 UI 유틸리티 컴포넌트를 재구성하는 데 중점을 둡니다. 이는 모듈성을 향상시키고, 빌드 시간을 단축하며, 프로젝트의 외부 라이브러리 사용을 정리하는 데 기여합니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request primarily focuses on refactoring the project's dependency management. It removes external dependencies such as ComposableArchitecture and SDWebImage from the App and DesignSystem modules, respectively, and updates the Tuist/Package.swift to reflect these changes. Furthermore, the Core module dependency has been removed from multiple feature modules including Bookmark, Detail, Launch, MyPage, Search, and Subscribe. The DesignSystem module is now imported into AppFlowCoordinatorView.swift, and a file previously attributed to the Shared module has been re-categorized under DesignSystem, indicating a consolidation or reorganization of UI components. There is no feedback to provide as no review comments were made.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>