Skip to content

refactor: MFA 0단계 — 유령 의존성 제거, 미사용 라이브러리 정리, SwipeBackHandler 이동#68

Merged
gomminjae merged 3 commits intodevelopfrom
feature/mfa-step0-cleanup
Mar 27, 2026
Merged

refactor: MFA 0단계 — 유령 의존성 제거, 미사용 라이브러리 정리, SwipeBackHandler 이동#68
gomminjae merged 3 commits intodevelopfrom
feature/mfa-step0-cleanup

Conversation

@gomminjae
Copy link
Copy Markdown
Owner

  • 6개 Feature(Bookmark, Detail, Search, Subscribe, MyPage, Launch)에서 미사용 Core 의존성 제거
  • SDWebImageSwiftUI, ComposableArchitecture 외부 의존성 완전 제거
  • SwipeBackHandler를 Shared → DesignSystem으로 이동 (UI 유틸리티 적절한 레이어 배치)
  • AppFlowCoordinatorView에 import DesignSystem 추가

- 6개 Feature(Bookmark, Detail, Search, Subscribe, MyPage, Launch)에서 미사용 Core 의존성 제거
- SDWebImageSwiftUI, ComposableArchitecture 외부 의존성 완전 제거
- SwipeBackHandler를 Shared → DesignSystem으로 이동 (UI 유틸리티 적절한 레이어 배치)
- AppFlowCoordinatorView에 import DesignSystem 추가

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 프로젝트의 의존성 구조를 리팩토링하여 사용되지 않는 의존성을 제거하고 UI 유틸리티 컴포넌트를 재구성하는 데 중점을 둡니다. 이는 모듈성을 향상시키고, 빌드 시간을 단축하며, 프로젝트의 외부 라이브러리 사용을 정리하는 데 기여합니다.

Highlights

  • 유령 의존성 제거: Bookmark, Detail, Search, Subscribe, MyPage, Launch 등 6개 Feature 모듈에서 사용되지 않는 Core 의존성을 제거했습니다.
  • 미사용 라이브러리 정리: SDWebImageSwiftUI 및 ComposableArchitecture 외부 의존성을 프로젝트에서 완전히 제거했습니다.
  • SwipeBackHandler 이동: SwipeBackHandler를 Shared 모듈에서 DesignSystem 모듈로 이동하여 UI 유틸리티의 적절한 레이어 배치를 개선했습니다.
  • DesignSystem 모듈 임포트 추가: AppFlowCoordinatorView에 DesignSystem 모듈 임포트를 추가했습니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on refactoring the project's dependency management. It removes external dependencies such as ComposableArchitecture and SDWebImage from the App and DesignSystem modules, respectively, and updates the Tuist/Package.swift to reflect these changes. Furthermore, the Core module dependency has been removed from multiple feature modules including Bookmark, Detail, Launch, MyPage, Search, and Subscribe. The DesignSystem module is now imported into AppFlowCoordinatorView.swift, and a file previously attributed to the Shared module has been re-categorized under DesignSystem, indicating a consolidation or reorganization of UI components. There is no feedback to provide as no review comments were made.

gomminjae and others added 2 commits March 27, 2026 00:02
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@gomminjae gomminjae merged commit c0d2790 into develop Mar 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant