FIX: Disallow Empty robot_name_prefix to prevent OIDC CLI login from being blocked
#22556
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
robot_name_prefixas non-empty so and empty/whitespace-only prefix cannot be saved.Why
string.HasPrefix(username, prefix)always being trueHow
Thanks to @stonezdj, I found clue how to handle this issue.
robot_name_prefixfromStringType toNonEmptyStringType`metadata.NewCfgValue(...)->ConfigureValue.Set(...)->ItemType.Validate(...). so empty/space-only values now returnErrStringValueIsEmptyand are rejected during config update.Issue being fixed
Fixes #22395
Please indicate you've done the following: