Fixed a bug in the Oracle driver of the gf framework where lowercase table names were not supported. - #4312
Closed
yuyinw wants to merge 16 commits into
Closed
Fixed a bug in the Oracle driver of the gf framework where lowercase table names were not supported.#4312yuyinw wants to merge 16 commits into
yuyinw wants to merge 16 commits into
Conversation
…Filter function caused lowercase table names to become unsupported.
…Filter function caused lowercase table names to become unsupported.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Oracle driver where lowercase table names were not supported. The issue stemmed from the driver removing all double quotes from SQL statements, which prevented Oracle from preserving case-sensitive identifiers (Oracle uses double quotes to maintain case sensitivity; without them, identifiers are converted to uppercase).
Key Changes:
- Removed the code in
oracle_do_filter.gothat stripped all double quotes from SQL statements - Updated test utilities to use double-quoted table names to preserve case sensitivity
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| contrib/drivers/oracle/oracle_do_filter.go | Removed the regex replacement that deleted all double quotes from SQL statements, allowing case-sensitive table names to be preserved |
| contrib/drivers/oracle/oracle_z_unit_init_test.go | Updated table creation and dropping to use double-quoted table names; simplified dropTable function and removed unused strings import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
感谢提交。这个修复已被你自己的 #4836 完整覆盖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景：在Oracle中，双引号用于标识区分大小写的标识符，包括表名。当表名用双引号括起来时，Oracle会保留其大小写，否则，Oracle会将标识符转换为大写
问题：oracle_do_filter.go文件DoFilter函数中newSql, err = gregex.ReplaceString(""", "", newSql)会将sql语句中“”全部删除，导致无法支持表名为小写的表。
解决：删除newSql, err = gregex.ReplaceString(""", "", newSql)