[DAP] Add --dap-port as a command line argument#92336
Merged
akien-mga merged 1 commit intogodotengine:masterfrom May 30, 2024
Merged
[DAP] Add --dap-port as a command line argument#92336akien-mga merged 1 commit intogodotengine:masterfrom
--dap-port as a command line argument#92336akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
Contributor
Author
|
@akien-mga what do you think? Also I have a question out of scope of this PR. |
adamscott
added
the
cherrypick:4.2
adamscott
reviewed
May 28, 2024
van800
force-pushed
the
DAP
branch
3 times, most recently
from
430cb0c to
d669553
Compare
akien-mga
changed the title
--dap-port as a command line argument
akien-mga
reviewed
May 29, 2024
akien-mga
approved these changes
May 30, 2024
AThousandShips
approved these changes
May 30, 2024
Member
|
Thanks! |
akien-mga
removed
the
cherrypick:4.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very similar to --lsp-port, which was added in #81844
I have started a conversation in https://chat.godotengine.org/channel/devel?msg=qEJuhGNKqXKsxmjZr, however haven't got responses so far.
The PR solves a case, when 2 GodotEditors are opened with projects and external editor tries to use one of the editors for debugging via DAP via Godot Editor (DebugAdapterServer, default port 6006).
In Rider already can start GodotEditor with LSP server in a headless mode, and this PR would help to use such GodotEditor also for debugging. Other external editors, which use DAP may also benefit from the PR.