Display human-readable descriptions for signal types in crash handlers#77286
Open
Calinou wants to merge 1 commit intogodotengine:masterfrom
Open
Display human-readable descriptions for signal types in crash handlers#77286Calinou wants to merge 1 commit intogodotengine:masterfrom
Calinou wants to merge 1 commit intogodotengine:masterfrom
Conversation
Member
|
Nice! My Excerpt from my |
Member
The signal handler is only registered for (same for macos) |
Member
Mh, this PR humanizes a few (arguably useful) extra signals though, so we either remove them from this PR or register them. |
Member
Author
|
I don't think we should add more signals to the crash handler, so I think it's best to remove the extra cases I added. |
Previously, only the signal number was displayed:
handle_crash: Program crashed with signal 4
Now, the signal code and description are shown:
handle_crash: Program crashed with signal 4 (SIGILL) - Illegal instruction
This only affects Linux and macOS, not Windows.
9b3f13d to
3b55a67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, only the signal number was displayed:
Now, the signal code and description are shown:
This only affects Linux and macOS, not Windows.