Define bold, italics and mono fonts in editor log for print_rich()#62860
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Oct 4, 2022
Merged
Conversation
This is also used by the number indicator for message grouping, as it uses a bold font. Mono font does not actually turn proportional fonts into monospace. Instead, it's a more faint version of the regular font, intended to emulate the look of the "faint" ANSI escape code (and make `[code]` distinguishable from regular text). The custom code font will be used to generate the bold/italic/mono variants if specified in the Editor Settings.
Member
|
This specific use case asks for an extra font option to prevent advance changes when embolden is used (to have all font variants with the same fixed width), but it's probably an overkill. |
Contributor
|
why make this workaround instead of use the same fonts created previously in this method, in example: |
Member
Author
These fonts are not fixed-width, so they're not consistent with the rest of the editor Output panel's font (which is a code font by default). |
KoBeWi
approved these changes
Oct 4, 2022
Member
KoBeWi
left a comment
There was a problem hiding this comment.
Looks ok. It makes sense to add these fonts, to make print_rich() more complete.
akien-mga
approved these changes
Oct 4, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #60675.
This is also used by the number indicator for message grouping, as it uses a bold font.
Mono font does not actually turn proportional fonts into monospace. Instead, it's a more faint version of the regular font, intended to emulate the look of the "faint" ANSI escape code (and make
[code]distinguishable from regular text).The custom code font will be used to generate the bold/italic/mono variants if specified in the Editor Settings.
Testing project: test_print_rich.zip
Preview
The font used here is Recursive Mono Casual, but this also works with the default editor code font.
Editor log
Editor log (custom font, Recursive Mono Casual Regular)
Terminal (VS Code)
Uses ANSI escape codes instead of BBCode.