Tree recursive folding (like Scene Tree Dock)#62666
Conversation
|
I went with |
f4c9ab1 to
d693b1f
Compare
|
Wasn't aware of the doctool check but now I know to verify that (sorry only fixed what I immediately saw in the failed check before I ran it), this shoudl be correct |
9392481 to
07bc615
Compare
|
Related (very old) PR: #36926. |
|
Intriguing! I thought I had exhaustively searched for this but must have missed this old case |
|
I'm not familiar with the process when something like this occurs is, so any directions would be appreciated |
876f1d9 to
64ea5d5
Compare
|
This should also fix #35529 |
|
Moved the disabling of recursive folding to the tree as I felt it doesn't make much sense in TreeItem, as one would have to disable it everywhere, and it would be confusing to decide what way that would control things anyway Also added the option to limit Will push once I've checked the last details on my end |
003d3e2 to
0c769a9
Compare
|
Note that with the addition of disabling it from the tree the original behavior in Scene Tree Dock could be kept for a subsequent PR by simply disabling it on the tree in Scene Tree, though I'm confident in my solution replicating previous the behavior reliably, i.e. if felt that the changes to Scene Tree Dock to accomodate this change should be done separately or by someone else |
78342c3 to
dbd439b
Compare
|
Made the context menu option in Filesystem Dock use recursive folding, leaving the instances in Visual Shader Editor alone as it is only one level deep, haven't found any other instance like this with a menu (will push once I've compiled locally) |
dbd439b to
5ca8fe4
Compare
f6b75c1 to
1284fe2
Compare
|
Looks good, but I'd rename |
|
Thank you, will take a look at all this tomorrow probably not doing so well today |
1284fe2 to
4c6a7d3
Compare
4c6a7d3 to
df9eaf5
Compare
|
Thanks! |
Moves the behavior of Scene Tree Dock recursively folding of trees into TreeItem:
set_collapsed_recursiveto collapse/uncollapse a TreeItem and all its descendantsis_any_collapsedto check if a TreeItem (with children) or any of its children (with children) are collapsedReplaced the functionality in Scene Tree Dock with this, and I haven't found anywhere else it is used but if anyone does please point it out and I can remove it there as well.
(The original approach in Scene Tree Dock was doing some redundant folding on shift click as it would fold the TreeItem and all descendants, but this would trigger each of those descendants to fold recursively on their own, not major and mostly unavoidable with the approach used, but it is a thing)