Improve crash handler message display#47829
Merged
Calinou merged 1 commit intogodotengine:masterfrom Aug 25, 2021
Merged
Conversation
fe2b54f to
8b34dea
Compare
akien-mga
reviewed
Jun 17, 2021
- State the Godot version and full hash in the backtrace. - Add decoration around the crash backtrace, both to make it stand out from other messages and help the user figure out what they should copy.
8b34dea to
8556dd1
Compare
reduz
approved these changes
Aug 24, 2021
Member
|
Cherry-picked for 3.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be merged independently of #33505.
I got the idea to implement this while looking at the comments here: #47732 (comment)
Preview
Before
After