Add unit tests for FontVariation - #122734
Draft
zaveshaa wants to merge 1 commit into
Draft
Conversation
Cover default property values, setter/getter round-trips, copy semantics of stored dictionaries, extra spacing validation (including out-of-bounds spacing types) and base font assignment including nested variations.
Member
Please do not use AI to write PR descriptions etc. |
Author
|
Understood, sorry about that — I rewrote the description in plain form and will keep descriptions concise going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
Adds unit tests for
FontVariation, which currently has none (its siblingFontFilealready has tests).New file
tests/scene/test_fontvariation.cpp:set_variation_opentype()/set_opentype_features()Additional information