Improve Find in Files support for built-in resources - #121945
Improve Find in Files support for built-in resources#121945TheDying0fLight wants to merge 1 commit into
Find in Files support for built-in resources#121945Conversation
ad79a92 to
fedfc98
Compare
That makes searching longer, no?
You can fetch Script/Shader resources from ResourceCache using their internal path/ID, and patch them if they exist, similar to #114300 |
Yes. If that is an issue I'd suggest an editor setting which can also be toggled directly in the
I tried this but had some issues. Now that I look at it again I have some new ideas to approach it and will look more closely at it tomorrow |
fedfc98 to
9ad04b5
Compare
Searching/Replacing now works in |
9ad04b5 to
1ee6e5d
Compare
97380c1 to
2580f07
Compare
2580f07 to
3bd9a52
Compare
What problem(s) does this PR solve?
Find in Files:Shaderresults intscnfile don't open shader editor #121969Find in Files: Selectingtscnresult located afterGDScriptresource opens it in script editor #121970Additional information
This PR tries to give search and replace in files decent support for built-in shaders/scripts
Features
Shadermatches in the shader editor when clicked ontscnwhich does not belong to a script that can be opened. Added an error messages for thistscnfiles forShader/GDScriptsub_resourcewhengd/gdshaderis set (even whentscnisn't)tscnfiles if the scene is open.Notes
Find in Filescurrently only searches through files on the disk and checks if they are open in editorsgdandgdshadercan be found_on_find_in_files_result_selectedtoEditorNodeand renamed it toedit_text_resourceso it can be reused (for example in Show shader editor on shader compilation error #112954)Scene open
Scene closed