CI: Clean up codespell ignores#120906
Open
Repiteo wants to merge 1 commit into
Open
Conversation
Repiteo
force-pushed
the
ci/codespell-cleanup
branch
from
e6e9a37 to
8c38ad0
Compare
aaronfranke
reviewed
Jul 3, 2026
| real_t nd = n.dot(res); | ||
| if (nd < d) { | ||
| d = nd; | ||
| real_t ndist = n.dot(res); |
Member
There was a problem hiding this comment.
We could rename n to segment_dir or segment_direction or something.
| int row = te->get_caret_line(); | ||
| int h = te->get_h_scroll(); | ||
| int v = te->get_v_scroll(); | ||
| CodeEdit *teditor = get_text_editor(); |
Contributor
Author
There was a problem hiding this comment.
That's what it was originally, but it turns out that it shadowed a private variable of the same name from a parent class. I suppose I could prepend an underscore to the private variable instead, which would let this be named text_editor safely
| real_t nd = n.dot(res); | ||
| if (nd < d) { | ||
| d = nd; | ||
| real_t ndist = n.dot(res); |
Member
There was a problem hiding this comment.
Another case where we should rename n to segment_direction or something.
Repiteo
force-pushed
the
ci/codespell-cleanup
branch
from
8c38ad0 to
e8b3c89
Compare
AThousandShips
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
Our number of codespell exceptions was overzealous, causing actual errors and bad practices to slip through the cracks. This PR strips out the majority of those ignored words, whether by addressing their use directly or ignoring instances that can't be reasonably worked around
Additional information
Adds a special regex to handle "colour" as an alias in documentation. Now codespell will ignore any text within a
keywordsblock