Fix crash in Project Settings when an autoload has been freed#120874
Open
meisekimiu wants to merge 1 commit into
Open
Fix crash in Project Settings when an autoload has been freed#120874meisekimiu wants to merge 1 commit into
meisekimiu wants to merge 1 commit into
Conversation
The `EditorAutoloadSettings` class does not expect an autoload node to be freed in between its initial instantiation and any calls to `update_autoload()`. But this actually *can* happen if the autoload is an editor script and happens to run something like `queue_free()` shortly after being initialized. When this happens, opening the project settings panel results in a crash, since the editor is trying to locate data such as the node's script after it has already been deleted. To fix this, just verify that the node still exists prior to accessing any of the node's data.
YeldhamDev
added
bug
topic:editor
crash
cherrypick:4.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
EditorAutoloadSettingsclass does not expect an autoload node to be freed in between its initial instantiation and any calls toupdate_autoload(). But this actually can happen if the autoload is an editor script and happens to run something likequeue_free()shortly after being initialized.When this happens, opening the project settings panel results in a crash, since the editor is trying to locate data such as the node's script after it has already been deleted.
To fix this, just verify that the node still exists prior to accessing any of the node's data.
What problem(s) does this PR solve?
@tooldeclarationqueue_free()on initialization.Additional information