Fix extracting materials without a per-material override#120870
Open
aaronfranke wants to merge 1 commit into
Open
Fix extracting materials without a per-material override#120870aaronfranke wants to merge 1 commit into
aaronfranke wants to merge 1 commit into
Conversation
aaronfranke
added
bug
topic:import
regression
topic:3d
cherrypick:4.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
Additional information
PR #115528 made it so that materials not present in
p_material_datawould be skipped and not extracted to external files. This could be argued to be better than the previous version of the code because it avoids an error, however,p_material_datadoes not contain information for materials that are not individually overridden in the Advanced Import Settings dialog, so when only using the Import dock, materials could not be extracted to files.I looked into what populates
p_material_data, and I believe it is correct to keep this empty for simple use cases involving only the Import dock. So, upon closer investigation, we should allow this to be empty, we just need to handle this case better, in a way that doesn't show any error messages.This PR fixes the code to handle this case, reads existing file paths instead of always overwriting them, permits individual materials to opt-out of extracting, and adds several comments to improve the clarity of the code.