Fix editor margins with modern theme and low spacing#120865
Draft
Kapparoti wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
Fixes the editor settings shortcuts and the main docks.
It also aims to fix other wrong margins that i'm currently searching.
Additional information
Renaming:
I used names similar to already-present theme type variations, but i think that removing the repetitive "Horizontal" from every name, making it implicit, would be better.
In this way, only "Bottom" would have to be specified, to make names less verbose, more clear and reusable.
EditorSettingsDialog:
With spacing=0, the editor settings clip on the right and bottom sides. To avoid this, should a MarginContainer be added between the container and the SectionedInspector?
SceneTreeDock :
I also found that the SceneTreeDock vertical scroll is always detached from the border, while the horizontal one detaches as spacing increases. In other docks, such as the FileSystem, this overlapping is not present. Is this intended?