Show renaming dialog when autoload auto name is invalid#119086
Open
KoBeWi wants to merge 1 commit intogodotengine:masterfrom
Open
Show renaming dialog when autoload auto name is invalid#119086KoBeWi wants to merge 1 commit intogodotengine:masterfrom
KoBeWi wants to merge 1 commit intogodotengine:masterfrom
Conversation
ajreckof
approved these changes
Apr 29, 2026
Member
ajreckof
left a comment
ajreckof
left a comment
There was a problem hiding this comment.
This looks good in terms of usability and code looks but haven't tested it.
For the failed checks it looks like headers are missing as it is passing in scu build only
KoBeWi
force-pushed
the
typical_naming_issue
branch
2 times, most recently
from
e2b2ec5 to
2dcadc6
Compare
KoBeWi
force-pushed
the
typical_naming_issue
branch
from
2dcadc6 to
f267b72
Compare
kleonc
reviewed
Apr 29, 2026
Comment on lines
+466
to
+467
| if (_autoload_name_is_valid(p_name)) { | ||
| _add_autoload(p_name, p_path); |
Member
There was a problem hiding this comment.
This checks against a wrong name, as _add_autoload afterwards does:
String autoload_name = p_name.to_pascal_case();The name should be modified before the validation instead of in _add_autoload (so for p_name = game_manager it will detect collision with class_name GameManager; currently it still doesn't work for MRP from #119055).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119055
godot.windows.editor.dev.x86_64_PYW5iIo0ou.mp4