GDScript: Add warning for shadowing global constants#117592
Closed
acs110113 wants to merge 1 commit intogodotengine:masterfrom
Closed
GDScript: Add warning for shadowing global constants#117592acs110113 wants to merge 1 commit intogodotengine:masterfrom
acs110113 wants to merge 1 commit intogodotengine:masterfrom
Conversation
Author
|
"Thanks for pointing that out! I'm glad to see this is being addressed in #106984. As this was my first attempt at contributing to Godot, I've learned a lot through the process. I'll close this PR in favor of the existing fix." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a missing warning in GDScript when a local variable or property shadows a global constant (such as
PI,OK, orINF).Previously, shadowing these global constants would happen silently, which could lead to confusing logic errors for users who expect to be using the built-in global values.
Fixes
Changes
gdscript_analyzer.cpp, added a check againstGDScriptLanguage::get_singleton()->get_global_map()within theis_shadowingvalidation logic.SHADOWED_VARIABLEwarning if a match is found in the global scope.Validation
Tested with the following script: