Fix inconsistent tooltip for @GlobalScope constants#117545
Open
EdwardChanCH wants to merge 1 commit intogodotengine:masterfrom
Open
Fix inconsistent tooltip for @GlobalScope constants#117545EdwardChanCH wants to merge 1 commit intogodotengine:masterfrom
@GlobalScope constants#117545EdwardChanCH wants to merge 1 commit intogodotengine:masterfrom
Conversation
Contributor
Author
|
Below is a full summary of what this PR fixed: class_name _Main
extends Node
var PI = -10 # Shows tooltip @GDScript.PI. <-- Fixed! Now no tooltip.
var OK = -20 # No tooltip.
enum Error { # No tooltip.
OK = -30 # No tooltip.
}
var Side = -40 # No tooltip.
var MouseButtonMask = -50 # No tooltip.
var number = -60 # No tooltip.
func _ready() -> void:
var _a = PI # Shows tooltip @GDScript.PI. <-- Fixed! Now shows _Main.PI.
var _b = TAU # Shows tooltip @GDScript.TAU.
var _c = OK # Shows tooltip _Main.OK.
var _d = FAILED # Shows tooltip @GlobalScope.FAILED.
var _e = Error # Shows tooltip _Main.Error.
var _f = Error.OK # Shows tooltips _Main.Error and _Main.OK.
#var _g = Error.FAILED # Shows tooltip _Main.Error.
var _h = Side # Shows tooltip _Main.Side.
#var _i = ClockDirection # Shows tooltip @GlobalScope.ClockDirection.
var _j = MouseButtonMask # Shows tooltips _Main.MouseButtonMask.
#var _k = JoyButton # Shows tooltips @GlobalScope.@JoyButton.
var _z = number # Shows _Main.number.
print(_a) # Prints -10
print(_b) # Prints 6.28318530717959
print(_c) # Prints -20
print(_d) # Prints 1
print(_e) # Prints { "OK": -30 }
print(_f) # Prints -30
print(_h) # Prints -40
print(_j) # Prints -50
print(_z) # Prints -60
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #106944
Related: #117308
Note: This is split from #106984, since the original PR became too bloated.