CI: Create CODEOWNERS validator hook#116646
Conversation
b994e12 to
8e840db
Compare
|
Note that this overlaps a bit with: I'd suggest rebasing on that to avoid collisions |
|
Indeed; this'll be integrated only after that's merged 👍 EDIT: It'll also need #111046, so the passed files use the correct syntax |
8e840db to
7edc955
Compare
|
Following the merge of #116130 and with the addition of a few extra rules, the amount of files without an owner is now 95: Details |
|
Tackled the last of the stragglers, so every file is now accounted for. I'm not thrilled at using a wildcard for |
|
I'll take a proper look tomorrow! |
AThousandShips
left a comment
There was a problem hiding this comment.
With the one caveat, looked at the validator script and it makes sense, though I'm not sure I fully get it but it seems to work!
A long, long overdue feature I've wanted for the repo was the ability to validate our
CODEOWNERSon-demand. Specifically: as a pre-commit hook. While there was the excellent codeowners ci tool, it didn't have a native pre-commit implementation, nor was it available in Python. This addresses both these points, by reimplementing the relevant logic as a Python script. Now we will know ahead of time if PRs are attempting to add files that would wind up without an owner!Marking as a draft for the time being, as the initial run of this found that there's currently 211 files without a codeowner! Before merging, we should ensure that each of these get a proper owner:
Details