Skip to content

Highlight selected points in Path3DEditor#114849

Merged
Repiteo merged 0 commit intogodotengine:masterfrom
TokageItLab:pathedit-selection
Feb 17, 2026
Merged

Highlight selected points in Path3DEditor#114849
Repiteo merged 0 commit intogodotengine:masterfrom
TokageItLab:pathedit-selection

Conversation

@TokageItLab
Copy link
Copy Markdown
Member

In EditMode (behavior dependent on Transform tool), selected points are displayed in blue. Yellow is used for ClosedPath and is difficult to distinguish from white, so I assume blue is fine.

Edit mode with Transform tool:
image

Edit mode with Select tool:
image

Add mode:
image

@TokageItLab TokageItLab added this to the 4.6 milestone Jan 11, 2026
@TokageItLab TokageItLab requested a review from a team January 11, 2026 06:59
@TokageItLab TokageItLab requested a review from a team January 11, 2026 06:59
Comment thread editor/scene/3d/path_3d_editor_plugin.cpp Outdated
Comment thread editor/scene/3d/path_3d_editor_plugin.cpp Outdated
Comment thread editor/scene/3d/path_3d_editor_plugin.cpp Outdated
Comment thread editor/scene/3d/path_3d_editor_plugin.cpp Outdated
@TokageItLab TokageItLab force-pushed the pathedit-selection branch 2 times, most recently from 90a97ba to 1ea8c83 Compare January 13, 2026 10:19
@akien-mga
Copy link
Copy Markdown
Member

CC @ryevdokimov @Calinou

@Repiteo Repiteo modified the milestones: 4.6, 4.x Jan 26, 2026
@TokageItLab TokageItLab requested review from Calinou and KoBeWi February 3, 2026 05:25
@ryevdokimov
Copy link
Copy Markdown
Contributor

Shouldn't all selected points turn blue or am I missing a reason why only one can be?

@TokageItLab TokageItLab marked this pull request as draft February 8, 2026 12:02
@TokageItLab TokageItLab force-pushed the pathedit-selection branch 4 times, most recently from fb86ca7 to a3bc87a Compare February 9, 2026 14:14
@TokageItLab TokageItLab marked this pull request as ready for review February 9, 2026 14:15
@TokageItLab TokageItLab requested a review from a team as a code owner February 9, 2026 14:15
@TokageItLab
Copy link
Copy Markdown
Member Author

@ryevdokimov Fixed. The selected point list is now retrieved from get_subgizmo_selection(), and the overall iteration for point drawing has been rearranged to make it easier to read.

@TokageItLab TokageItLab modified the milestones: 4.x, 4.7 Feb 9, 2026
Copy link
Copy Markdown
Contributor

@ryevdokimov ryevdokimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, code looks fine to me.

2026-02-09.20-02-02.mp4

@Repiteo Repiteo merged commit c4a893e into godotengine:master Feb 17, 2026
20 checks passed
@Repiteo
Copy link
Copy Markdown
Contributor

Repiteo commented Feb 17, 2026

Thanks!

@akien-mga
Copy link
Copy Markdown
Member

For the record, GitHub seems bugged out on this merge batch and the PR view shows "0 commits", but the commit which was merged is indeed present in the master branch: 163b498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Curve3D Select Points tool non-functional

5 participants