Add custom upscaler implementation to RD renderer#114670
Open
BastiaanOlij wants to merge 1 commit intogodotengine:masterfrom
Open
Add custom upscaler implementation to RD renderer#114670BastiaanOlij wants to merge 1 commit intogodotengine:masterfrom
BastiaanOlij wants to merge 1 commit intogodotengine:masterfrom
Conversation
BastiaanOlij
force-pushed
the
custom_upscaler
branch
from
b0814d9 to
62ca24d
Compare
BastiaanOlij
force-pushed
the
custom_upscaler
branch
from
62ca24d to
2943022
Compare
|
Is it planned to also migrate the builtin upscalers (like MetalFX, FSR1 and 2) to this API? This would reduce some duplicate code in render_forward_clustered.cpp. |
Contributor
Author
Not at this time, and it would only be able to replace FSR2 and Temporal MetalFX if we choose to do so. Implementing those two as subclasses of this does make sense to me, but I think that should be a longer term goal. |
ChloePrime
reviewed
Jan 21, 2026
BastiaanOlij
force-pushed
the
custom_upscaler
branch
from
2943022 to
da761dc
Compare
BastiaanOlij
force-pushed
the
custom_upscaler
branch
from
da761dc to
cb0f4a6
Compare
BastiaanOlij
force-pushed
the
custom_upscaler
branch
from
cb0f4a6 to
6de618a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a solution to allow creation of custom upscalers. It's based on the same approach we've used for compositor effects, e.g once configured the rendering engine does a callback into the custom code to perform the actual upscaling.
The current approach only targets Forward+ and performs upscaling right after 3D rendering but before post processing similar to FSR2 and Temporal MetalFX. In theory you should be able to re-implement either using this approach.
Very simple test project that does a 2x2 upscale:
https://codeberg.org/BastiaanOlij/test-custom-upscaler
Only outstanding issue that I'm not sure how to solve is that I can't set project settings for this so the default viewport is setup with a custom upscaler. The main issue here is that we suppress MetalFX, so adding Custom as a enum at the end is not possible (unless there is an alternative way to fill the dropdown).
Implements: godotengine/godot-proposals#13718