GI: Cache repeated itos() calls for SDFGI#114538
Open
kellemar wants to merge 1 commit intogodotengine:masterfrom
Open
GI: Cache repeated itos() calls for SDFGI#114538kellemar wants to merge 1 commit intogodotengine:masterfrom
kellemar wants to merge 1 commit intogodotengine:masterfrom
Conversation
Member
|
Do you have some comparison data on the effects of this? Please see our optimization guidelines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of calling itos() repeatedly for LIGHTPROBE_OCT_SIZE, this caches itos(SDFGI::LIGHTPROBE_OCT_SIZE) and itos(SDFGI::SH_SIZE) at the start of the SDFGI initialization block.
Minor optimization during engine init, which avoids redundant int-to-string conversions.