Change TabContainer's popup button into real Button - #114283
Merged
Merged
Conversation
ghost
reviewed
Dec 22, 2025
KoBeWi
force-pushed
the
adding_physical_buttons
branch
from
December 22, 2025 23:45
13c1325 to
4840437
Compare
lodetrick
reviewed
Dec 23, 2025
Contributor
|
Does it make sense to change the return type of |
Member
Author
|
The method is not exposed. |
KoBeWi
force-pushed
the
adding_physical_buttons
branch
from
February 7, 2026 05:10
4840437 to
85283af
Compare
KoBeWi
force-pushed
the
adding_physical_buttons
branch
from
February 8, 2026 12:04
85283af to
c8570b1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
KoBeWi
force-pushed
the
adding_physical_buttons
branch
from
February 8, 2026 16:06
c8570b1 to
e2cd7f4
Compare
KoBeWi
force-pushed
the
adding_physical_buttons
branch
from
February 8, 2026 17:13
e2cd7f4 to
44f9d7f
Compare
YeldhamDev
approved these changes
Feb 8, 2026
YeldhamDev
left a comment
YeldhamDev
left a comment
Member
There was a problem hiding this comment.
Everything seems to be in order.
Contributor
|
Thanks! |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…tons Change TabContainer's popup button into real Button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reorganizes TabContainer's internals. The popup button, which used to be drawn manually, is now a real button and is placed inside a new internal HBoxContainer, next to the TabBar. This allowed to simplify the logic and remove some hacks. The functionality/appearance should be more or less the same.
Needed for #113051