Skip to content

Fix bottom panel focus not showing - #114241

Open
lodetrick wants to merge 1 commit into
godotengine:masterfrom
lodetrick:dock-focus
Open

Fix bottom panel focus not showing#114241
lodetrick wants to merge 1 commit into
godotengine:masterfrom
lodetrick:dock-focus

Conversation

@lodetrick

Copy link
Copy Markdown
Contributor

Fixes #113898

There are no hints for focus on the bottom panel (the focus stylebox is invisible) so it is hard to tell when the bottom panel has focus. This PR adds the focus hint to both themes mirroring the TabContainer's focus hint.

Classic Modern

@lodetrick
lodetrick requested review from a team as code owners December 20, 2025 12:32
@lodetrick lodetrick changed the title Add focus hints to the bottom panel Fix bottom panel focus not showing Dec 20, 2025
@YeldhamDev

Copy link
Copy Markdown
Member

How does this fixes the issue?

@KoBeWi

KoBeWi commented Dec 20, 2025

Copy link
Copy Markdown
Member

I think the idea is to make bottom panel consistent with other docks?
tbh maybe you could do the opposite and remove the focus from side docks. I encountered a similar problem in #113051

@YeldhamDev

YeldhamDev commented Dec 20, 2025

Copy link
Copy Markdown
Member

I think showing the focus on keyboard input is fine, but it shouldn't show it by just having it opened by selecting a node/resource.

@lodetrick

lodetrick commented Dec 20, 2025

Copy link
Copy Markdown
Contributor Author

This PR is for consistency, yes. It is just for the theming and not for the actual taking of focus (which I do think should change, but that would be in a separate PR).

The choice is either to show focus on both or neither, I think inconsistency is bad here. I'm partial to both because it gives more information to the user and once force focusing is fixed it should only be done intentionally through keyboard input.

@Calinou Calinou added this to the 4.x milestone Dec 21, 2025
@Repiteo
Repiteo requested a review from a team as a code owner February 17, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Godot shows a blue rectangle over TileMap

4 participants